fix(resolver): response format and evaluator metrics in deactivated branch#3152
fix(resolver): response format and evaluator metrics in deactivated branch#3152icecrasher321 merged 4 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@cursor review |
Greptile OverviewGreptile SummaryFixed variable resolution in deactivated workflow branches by exposing output schemas for evaluator metrics and agent response formats, even when blocks haven't executed. This enables proper validation and autocomplete for variable references like Key Changes:
Technical Context: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Executor as Workflow Executor
participant BlockData as collectBlockData()
participant GetSchema as getBlockSchema()
participant Evaluator as getEvaluatorMetricsSchema()
participant ResponseFmt as getResponseFormatSchema()
participant Resolver as Variable Resolver
Executor->>BlockData: Collect block data and schemas
loop For each block in workflow
BlockData->>GetSchema: Get output schema for block
alt Block has inputFormat outputs
GetSchema-->>BlockData: Return merged inputFormat schema
else Block is evaluator
GetSchema->>Evaluator: Check evaluator metrics
Evaluator-->>GetSchema: Return metrics schema (even if not executed)
GetSchema-->>BlockData: Return evaluator schema
else Block has responseFormat
GetSchema->>ResponseFmt: Parse responseFormat param
ResponseFmt-->>GetSchema: Return parsed schema (even if not executed)
GetSchema-->>BlockData: Return response format schema
else Block is trigger or has outputs
GetSchema-->>BlockData: Return block outputs
end
end
BlockData-->>Executor: blockOutputSchemas for all blocks
Note over Resolver: Variable references can now be validated<br/>even for non-executed blocks in deactivated branches
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…ranch (#3152) * fix(resolver): response format in deactivated branch * add evaluator metrics too * add child workflow id to the workflow block outputs * cleanup typing
* feat(skills): added skills to agent block * improvement(skills): audit fixes, docs, icon, and UX polish * fix(skills): consolidate redundant permission checks in POST and DELETE * more friendly error for duplicate skills in the same workspace * fix(executor): loop sentinel-end wrongly queued (#3148) * fix(executor): loop sentinel-end wrongly queued * fix nested subflow error highlighting * fix(linear): align tool outputs, queries, and pagination with API (#3150) * fix(linear): align tool outputs, queries, and pagination with API * fix(linear): coerce first param to number, remove duplicate conditions, add null guard * fix(resolver): response format and evaluator metrics in deactivated branch (#3152) * fix(resolver): response format in deactivated branch * add evaluator metrics too * add child workflow id to the workflow block outputs * cleanup typing * feat(slack): add file attachment support to slack webhook trigger (#3151) * feat(slack): add file attachment support to slack webhook trigger * additional file handling * lint * ack comment * fix(skills): hide skill selection when disabled, remove dead code --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Summary
Response format in not executed agent block and evaluator metrics should still be treated as accurate.
Type of Change
Testing
Tested manually
Checklist